Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcode git clone for the jenkins #2038

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Remove hardcode git clone for the jenkins #2038

merged 2 commits into from
Apr 26, 2022

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Remove hardcode git clone for the jenkins

Issues Resolved

#1901

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Remove hardcode git clone for the jenkins
d343ae7 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added enhancement New Enhancement cicd jenkins Jenkins related issue labels Apr 26, 2022
@peterzhuamazon peterzhuamazon self-assigned this Apr 26, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner April 26, 2022 17:09
@peterzhuamazon peterzhuamazon mentioned this pull request Apr 26, 2022
Closed
@peterzhuamazon peterzhuamazon linked an issue Apr 26, 2022 that may be closed by this pull request
Remove hardcoded git repo checkout for the repo opensearch-build #1901
Closed
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #2038 (d343ae7) into main (b9f83df) will increase coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2038      +/-   ##
============================================
+ Coverage     94.23%   94.64%   +0.40%     
============================================
  Files           198      152      -46     
  Lines          3902     3732     -170     
  Branches         29       19      -10     
============================================
- Hits           3677     3532     -145     
+ Misses          219      200      -19     
+ Partials          6        0       -6
Impacted Files Coverage Δ
src/manifests_workflow/input_manifests.py 98.97% <ø> (ø)
src/jenkins/BundleManifest.groovy
...bs/PrintArtifactDownloadUrlsForStaging_Jenkinsfile
...ests/jenkins/jobs/CopyContainer_docker_Jenkinsfile
tests/jenkins/jobs/PostCleanup_Jenkinsfile
...ests/jenkins/jobs/AssembleManifest_tar_Jenkinsfile
...rtifacts_actions_OpenSearch_Dashboards_Jenkinsfile
tests/jenkins/jobs/GetManifestSHA_Jenkinsfile
tests/jenkins/jobs/PromoteArtifacts_Jenkinsfile
tests/jenkins/jobs/BuildDockerImage_Jenkinsfile
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b439dcb...d343ae7. Read the comment docs.

@tianleh
Copy link
Member

tianleh commented Apr 26, 2022

Thanks for the improvement! Finally no need to change multiple places during local branch testing.

Please fix the failed Groovy tests before merging.

@peterzhuamazon
Update txt tests
40c79ea 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit dcfc3f0 into opensearch-project:main Apr 26, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-remove-hardcode branch April 26, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zelinh zelinh zelinh approved these changes

@tianleh tianleh tianleh approved these changes

@dblock dblock dblock approved these changes

Assignees

@peterzhuamazon peterzhuamazon

Labels
cicd enhancement New Enhancement jenkins Jenkins related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hardcoded git repo checkout for the repo opensearch-build
5 participants
@peterzhuamazon @codecov-commenter @tianleh @dblock @zelinh